👋 Welcome back rrich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@reinrich This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8348678: [PPC64] C2: unaligned vector load/store is ok
8343906: test2 of compiler/c2/TestCastX2NotProcessedIGVN.java fails on some platforms

Reviewed-by: mdoerr, amitkumar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 40 new commits pushed to the master branch:

• cbe9ec5: 8348905: Add support to specify the JDK for compiling Jtreg tests
• 6b581d2: 8347997: assert(false) failed: EA: missing memory path
• 4662363: 8348687: [BACKOUT] C2: Non-fluid StringBuilder pattern bails out in OptoStringConcat
• d266ca9: 8348752: Enable -XX:+AOTClassLinking by default when -XX:AOTMode is specified
• cbc89a7: 8348898: Remove unused OctalDigits to clean up code
• 96fefed: 8319850: PrintInlining should print which methods are late inlines
• 51cce6e: 8318577: Windows Look-and-Feel JProgressBarUI does not render correctly on 2x UI scale
• 6bfae3a: 8333386: TestAbortOnVMOperationTimeout test fails for client VM
• f98d9a3: 8348870: Eliminate array bound checks in DecimalDigits
• fe6d9ab: 8348582: Set -fstack-protector when building with clang
• ... and 30 more: https://git.openjdk.org/jdk/compare/ad01dfb670215a35d4151c7129c9086888e1f9e8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

/issue JDK-8343906

@reinrich
Adding additional issue to issue list: 8343906: test2 of compiler/c2/TestCastX2NotProcessedIGVN.java fails on some platforms.

@reinrich The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Webrevs

• 03: Full - Incremental (5071209a)
• 02: Full - Incremental (296adbc6)
• 01: Full - Incremental (20dae18d)
• 00: Full (c75622fa)

@offamitkumar JDK-8343906 states that the test also fails on s390x.
This must have another reason then since misaligned_vectors_ok returns already true on s390x:

Should AlignVector be disabled regardless of the Power Architecture version? SuperwordUseVSX already requires Power8. The 8 Byte load/store instructions which are used otherwise have no alignment requirements, either. But, Power7 is basically dead and the support will probably be removed, soon (https://bugs.openjdk.org/browse/JDK-8331859). So, I'm ok with it.

Thanks for looking at this.

Should AlignVector be disabled regardless of the Power Architecture version? SuperwordUseVSX already requires Power8. The 8 Byte load/store instructions which are used otherwise have no alignment requirements, either.

Ah, indeed. But I think there's an issue though with the displacement which needs to be 4 byte aligned, doesn't it? Maybe that's why AlignVector wasn't disabled yet.
And maybe there's even an issue with +SuperwordUseVSX if nodes with n->as_LoadVector()->memory_size() == 8 are generated?

The displacement should be handled by the memoryAlg4 operands. (Should be checked.) It may make sense to switch off AlignVector even without SuperwordUseVSX (on any Power Architecture).

The displacement should be handled by the memoryAlg4 operands. (Should be checked.)

Of course. I should play more often with them AD files.

It may make sense to switch off AlignVector even without SuperwordUseVSX (on any Power Architecture).

Done.
I've looked at a little example where bytes from a long[] are copied to a byte[] varying a constant offset. The stores were always merged into a std instruction independently of AlignVector also I couldn't get it to use 16 byte load/stores. Would be interesting to find out why...

Thanks for the reviews.
/integrate

Going to push as commit 1a8212e.
Since your change was applied there have been 170 commits pushed to the master branch:

• 41bdc47: 8208377: Soft hyphens render if not using TextLayout
• df654a9: 8349752: Tier1 build failure caused by JDK-8349178
• 527489c: 8349284: Make libExplicitAttach work on static JDK
• f11a737: 8349475: Test tools/javac/api/TestJavacTaskWithWarning.java writes files in src dir
• b737f7f: 8349501: Relocate supporting classes in security/testlibrary to test/lib/jdk tree
• 84b32cb: 8349178: runtime/jni/atExit/TestAtExit.java should be supported on static JDK
• ab66c82: 8349639: jfr/event/gc/detailed/TestShenandoahEvacuationInformationEvent.java fails to compile after JDK-8348610
• f74c4df: 8349580: Do not use address in MemTracker top level functions
• c9cadbd: 8346567: Make Class.getModifiers() non-native
• 5589892: 8343074: test/jdk/com/sun/net/httpserver/docs/test1/largefile.txt could be generated
• ... and 160 more: https://git.openjdk.org/jdk/compare/ad01dfb670215a35d4151c7129c9086888e1f9e8...master

Your commit was automatically rebased without conflicts.

@reinrich Pushed as commit 1a8212e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.